Discussion:
[PATCH] attachment tree improvement
Dennis Preiser
2010-10-17 17:17:51 UTC
Permalink
It turns out that the current code does not handle deeply nested
attachments very well. Attached patch changes the behavior the following
way:

The attachment tree behaves like the thread tree now, so it 'wraps' if
the right edge (minus strlen(txt_attachment_no_name)) is reached. I
adopted the code from thread.c:make_prefix() for this.

Also attached a sample mbox with deeply nested parts for testing.

Dennis
Dennis Preiser
2010-10-29 14:39:24 UTC
Permalink
Post by Dennis Preiser
It turns out that the current code does not handle deeply nested
attachments very well. Attached patch changes the behavior the following
The attachment tree behaves like the thread tree now, so it 'wraps' if
the right edge (minus strlen(txt_attachment_no_name)) is reached. I
adopted the code from thread.c:make_prefix() for this.
Attached a revised version of this patch which supersedes the previous
one. The screen layout now depends on the screenwidth and on whether the
tree wraps or not. If the tree wraps, the tree gets more space, if the
tree does not wrap, the info at the right side gets more space.

In addition, the patch fixes the broken Attachment Menu when building
with '--with-screen=termcap'. The menu was not properly drawn in this
case.

Dennis

Loading...